Joe McDonnell has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22532 )
Change subject: IMPALA-13781: Fix "Median Diff %" for report_benchmark_results.py ...................................................................... IMPALA-13781: Fix "Median Diff %" for report_benchmark_results.py The calculation that report_benchmark_results.py uses for "Median Diff %" is using the wrong divisor. For an AB test, it should be dividing by the base median time (i.e. A), but this is actually dividing by the new median time (i.e. B). That gives the wrong range and can result in "Median Diff %" values of >100%. This fixes the calculation to divide by the base median time (i.e. A). Change-Id: I6f9da14bc7d5b6ef6a795b9024760f8cae77d72f Reviewed-on: http://gerrit.cloudera.org:8080/22532 Reviewed-by: Riza Suminto <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M tests/benchmark/report_benchmark_results.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Riza Suminto: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/22532 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I6f9da14bc7d5b6ef6a795b9024760f8cae77d72f Gerrit-Change-Number: 22532 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
