Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22560 )
Change subject: IMPALA-13805: Fix TSAN build failures for the runtime-profile-test ...................................................................... IMPALA-13805: Fix TSAN build failures for the runtime-profile-test The shared memory of a rapidjson document's value containing event sequences was being utilized through a reference pointer, instead of referencing by value, while generating the aggregated event sequences. During thread sanitization builds, such values were cleared, resulting in test failures. This has been fixed by correctly passing values through reference, instead of the shared memory address. Tested locally by building with TSAN opts. Change-Id: Ibdea503d032d456746e9cb4f19d0057197ddb117 Reviewed-on: http://gerrit.cloudera.org:8080/22560 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/util/runtime-profile.cc M be/src/util/runtime-profile.h 2 files changed, 4 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22560 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ibdea503d032d456746e9cb4f19d0057197ddb117 Gerrit-Change-Number: 22560 Gerrit-PatchSet: 7 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]>
