Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22559 )
Change subject: IMPALA-11402: Add limit on files fetched by a single getPartialCatalogObject request ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22559/1/bin/start-impala-cluster.py File bin/start-impala-cluster.py: http://gerrit.cloudera.org:8080/#/c/22559/1/bin/start-impala-cluster.py@a1138 PS1, Line 1138: > Should this be part of this change? It seemed unrelated to me. Oops, this should be discarded. I removed this to be able to start a single impalad without catalogd running since I deployed catalogd on another machine. http://gerrit.cloudera.org:8080/#/c/22559/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/22559/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2392 PS1, Line 2392: numFds > Was this intentionally changed from 'numFilesFiltered'? 'numFds' is also in Oops, this is a mistake.. http://gerrit.cloudera.org:8080/#/c/22559/1/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@2417 PS1, Line 2417: LOG.warn("Collected {} file descriptors of {} partitions for table {}. " + > We could also include the number of requested file descriptors in the log. We don't know the number of requested file descriptors until we iterate through all the requested partitions. Here we are going to break the loop. So we can only log the requested number of partitions. Added the new info. -- To view, visit http://gerrit.cloudera.org:8080/22559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb13fec20de5a17e7fc33613ca5cdebb9ac1a1e5 Gerrit-Change-Number: 22559 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Mon, 03 Mar 2025 02:58:43 +0000 Gerrit-HasComments: Yes
