Riza Suminto has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22564 )
Change subject: IMPALA-13716 (Addendum): Simplify the call site of createSingleNodePlan() ...................................................................... IMPALA-13716 (Addendum): Simplify the call site of createSingleNodePlan() IMPALA-13716 added an input argument to createSingleNodePlan() that requires the caller to provide a List of TupleIsNullPredicate. Since this List depends only on the given PlanNode, this patch adds a method that computes this List when it is not provided by the caller, which simplifies the call site as well. This patch also moves getTupleIsNullPreds() to AnalyticPlanner.java because it is only used in AnalyticPlanner.java. We make the method a static one because it's not specific to an instance of AnalyticPlanner.java. Change-Id: Ie10361f15db4c0eb2cf5ff5f4d0a28c612b1a930 Reviewed-on: http://gerrit.cloudera.org:8080/22564 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Riza Suminto <[email protected]> --- M fe/src/main/java/org/apache/impala/planner/AnalyticPlanner.java M fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java 2 files changed, 18 insertions(+), 10 deletions(-) Approvals: Impala Public Jenkins: Verified Riza Suminto: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ie10361f15db4c0eb2cf5ff5f4d0a28c612b1a930 Gerrit-Change-Number: 22564 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]>
