Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22353 )
Change subject: IMPALA-13586: Initial support for Iceberg REST Catalogs ...................................................................... Patch Set 4: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22353/4/tests/custom_cluster/test_iceberg_rest_catalog.py File tests/custom_cluster/test_iceberg_rest_catalog.py: http://gerrit.cloudera.org:8080/#/c/22353/4/tests/custom_cluster/test_iceberg_rest_catalog.py@25 PS4, Line 25: from tests.common.skip import SkipIfFS flake8: F401 'tests.common.skip.SkipIfFS' imported but unused http://gerrit.cloudera.org:8080/#/c/22353/4/tests/custom_cluster/test_iceberg_rest_catalog.py@58 PS4, Line 58: ' flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/22353/4/tests/custom_cluster/test_iceberg_rest_catalog.py@59 PS4, Line 59: s flake8: E122 continuation line missing indentation or outdented http://gerrit.cloudera.org:8080/#/c/22353/4/tests/custom_cluster/test_iceberg_rest_catalog.py@60 PS4, Line 60: p flake8: E122 continuation line missing indentation or outdented -- To view, visit http://gerrit.cloudera.org:8080/22353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1722b898b568d2f5689002f2b9bef59320cb088c Gerrit-Change-Number: 22353 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 04 Mar 2025 16:55:52 +0000 Gerrit-HasComments: Yes
