Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22425 )
Change subject: IMPALA-12959: Calcite planner: Implement count star optimization... ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/22425/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22425/8//COMMIT_MSG@38 PS8, Line 38: aggregation substitution map was set. This does not apply to Calcite whic typo: which, and extra space at sentence end. It'd also be nice to have a blank line before the Change-Id. http://gerrit.cloudera.org:8080/#/c/22425/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java: http://gerrit.cloudera.org:8080/#/c/22425/7/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaHdfsScanRel.java@253 PS7, Line 253: private SlotDescriptor createCountStarOptimizationDesc(TupleDescriptor tupleDesc, > Good idea. Moved this method as a public static method in ScanNode. Can you remove this method now? -- To view, visit http://gerrit.cloudera.org:8080/22425 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I975beefedd2cceb34dad0f93343a46d1b7094c13 Gerrit-Change-Number: 22425 Gerrit-PatchSet: 8 Gerrit-Owner: Steve Carlin <scar...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Steve Carlin <scar...@cloudera.com> Gerrit-Comment-Date: Wed, 05 Mar 2025 22:14:21 +0000 Gerrit-HasComments: Yes
