Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22582 )
Change subject: IMPALA-13826: Replace imp with importlib in the config generator ...................................................................... Patch Set 1: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22582/1/bin/generate_xml_config.py File bin/generate_xml_config.py: http://gerrit.cloudera.org:8080/#/c/22582/1/bin/generate_xml_config.py@96 PS1, Line 96: def load_source_with_importlib(modname, filename): flake8: E302 expected 2 blank lines, found 1 http://gerrit.cloudera.org:8080/#/c/22582/1/bin/generate_xml_config.py@112 PS1, Line 112: def import_template(name, module_path): flake8: E302 expected 2 blank lines, found 1 -- To view, visit http://gerrit.cloudera.org:8080/22582 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I472d093eeaac97a380d444a1756b54f825b2d031 Gerrit-Change-Number: 22582 Gerrit-PatchSet: 1 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 05 Mar 2025 22:45:58 +0000 Gerrit-HasComments: Yes
