Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/9943 )
Change subject: IMPALA-5706: Spilling sort optimisations ...................................................................... Patch Set 17: Verified+1 I've spent some time (way more than wanted to:) ) to fix test_multiple_mem_limit, however no matter what I tried the assert on the number of merges kept failing in gerrit-verify-dryrun meanwhile it succeeded both locally and in any other jenkins build I tried. I decided to remove the assert on # of merges from that test as I haven't found a way to make it succeed in the verify job. Now it's all green: https://jenkins.impala.io/job/gerrit-verify-dryrun/2560/ -- To view, visit http://gerrit.cloudera.org:8080/9943 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74857c1694802e81f1cfc765d2b4e8bc644387f9 Gerrit-Change-Number: 9943 Gerrit-PatchSet: 17 Gerrit-Owner: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Gabor Kaszab <gaborkas...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 29 May 2018 07:17:51 +0000 Gerrit-HasComments: No