Balazs Jeszenszky has posted comments on this change. ( http://gerrit.cloudera.org:8080/10525 )
Change subject: IMPALA-6714: [DOCS] ORC file format support ...................................................................... Patch Set 1: (6 comments) Thanks for doing this! http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_file_formats.xml File docs/topics/impala_file_formats.xml: http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_file_formats.xml@115 PS1, Line 115: parquet orc http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_file_formats.xml@124 PS1, Line 124: Before that, create the table using Hive. Remove - before 2.12, Impala won't be able to query anyway, right? http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml File docs/topics/impala_orc.xml: http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@93 PS1, Line 93: If you do not have an existing data file to use, begin by creating one in the appropriate format. The example below should be enough, remove. http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@152 PS1, Line 152: Enabling Compression for ORC Tables This section deals mostly with Hive - is there a Hive document that could be referenced instead including the commands? http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@260 PS1, Line 260: Most of the types have the same name in Impala except the BINARY type is STRING type in Impala, : and the DATE type is not supported in Impala. Turn into list (or box, similar to what Parquet has) http://gerrit.cloudera.org:8080/#/c/10525/1/docs/topics/impala_orc.xml@269 PS1, Line 269: For example, Add examples of what works, and one which doesn't. Include exception text. -- To view, visit http://gerrit.cloudera.org:8080/10525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib1ee23ed844653c274babdce5a332dbe5c79b630 Gerrit-Change-Number: 10525 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Balazs Jeszenszky <jes...@gmail.com> Gerrit-Comment-Date: Tue, 29 May 2018 09:28:05 +0000 Gerrit-HasComments: Yes
