Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22572 )
Change subject: IMPALA-13823: Clear existing entry of TMP_DIRS at cluster_setup ...................................................................... IMPALA-13823: Clear existing entry of TMP_DIRS at cluster_setup Assertion was hit at CustomClusterTestSuite.make_tmp_dir() for attempting to create tmp dir that already have mapping in CustomClusterTestSuite.TMP_DIRS. It can happen if different custom cluster tests run declare the same tmp_dir_placeholders, and one of the earlier run fail to teardown properly, resulting in clear_tmp_dirs() not being called. This patch fix the issue by clearing existing TMP_DIRS entry without removing the underlying filesystem path. Along with it, a WARN log will be printed, saying about dirty entry in TMP_DIRS. Testing: - Manually comment clear_tmp_dirs() call in cluster_teardown() and run TestQueryLogTableBufferPool.test_select. Confirmed that all 4 of its test runs complete, the warning logs printed to logs/custom_cluster_tests/results/TEST-impala-custom-cluster.xml and the tmp dir stays in logs/custom_cluster_tests/. Change-Id: I3f528bb155eb3cf4dfa58a6a23feb438809556bc Reviewed-on: http://gerrit.cloudera.org:8080/22572 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M tests/common/custom_cluster_test_suite.py 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I3f528bb155eb3cf4dfa58a6a23feb438809556bc Gerrit-Change-Number: 22572 Gerrit-PatchSet: 4 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
