Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21762 )
Change subject: IMPALA-13333: Limit memory estimation if PlanNode can spill ...................................................................... Patch Set 35: (3 comments) http://gerrit.cloudera.org:8080/#/c/21762/33/common/thrift/ImpalaService.thrift File common/thrift/ImpalaService.thrift: http://gerrit.cloudera.org:8080/#/c/21762/33/common/thrift/ImpalaService.thrift@1018 PS33, Line 1018: of them is set. : // Setting to 0.0 or unsetting scratch_dirs flag will re > I think this contradicts the statement above that, "Setting value closer to I prefer to leave out 0.0 if it is OK. The reason is, it conforms with other fractional query option that rejects value < 0.0 (see query-option-test.cc). I update the docs in ps34. http://gerrit.cloudera.org:8080/#/c/21762/31/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21762/31/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@765 PS31, Line 765: > mem_limit will be clamped if clamp_mem_limit_query_option is set in pool co Done in ps34. http://gerrit.cloudera.org:8080/#/c/21762/33/fe/src/main/java/org/apache/impala/analysis/Analyzer.java File fe/src/main/java/org/apache/impala/analysis/Analyzer.java: http://gerrit.cloudera.org:8080/#/c/21762/33/fe/src/main/java/org/apache/impala/analysis/Analyzer.java@765 PS33, Line 765: > mem_limit is also clamped when clamp_mem_limit_query_option is set in pool Done. Although, I might need to wait until https://gerrit.cloudera.org/c/22329 merged and update this logic again. -- To view, visit http://gerrit.cloudera.org:8080/21762 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I290c4e889d4ab9e921e356f0f55a9c8b11d0854e Gerrit-Change-Number: 21762 Gerrit-PatchSet: 35 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 07 Mar 2025 02:05:49 +0000 Gerrit-HasComments: Yes
