Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22591 )
Change subject: IMPALA-13841: Refactor AnalysisResult to make it immutable and simpler ...................................................................... Patch Set 9: Code-Review+1 (1 comment) I see you have separate discussion with Joe about AnalysisDriver https://gerrit.cloudera.org/c/22306/11/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java#575 Will be great to have Joe review this too. http://gerrit.cloudera.org:8080/#/c/22591/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22591/8//COMMIT_MSG@12 PS8, Line 12: The AnalysisResult class should be an class with immutable members with : the results obtained from analyzing the query > Done Done -- To view, visit http://gerrit.cloudera.org:8080/22591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaf8854b1ce18c72a49893fc36e2cea77b7a2485 Gerrit-Change-Number: 22591 Gerrit-PatchSet: 9 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 10 Mar 2025 23:22:58 +0000 Gerrit-HasComments: Yes
