Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22610 )

Change subject: IMPALA-13853: Don't adjust Iceberg field IDs for data files 
that don't have complex types
......................................................................


Patch Set 1:

(2 comments)

Thanks for the comments!

http://gerrit.cloudera.org:8080/#/c/22610/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22610/1//COMMIT_MSG@17
PS1, Line 17: This
> Nit: "These adjustments are not needed..."
Done


http://gerrit.cloudera.org:8080/#/c/22610/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-orc.test
File 
testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-orc.test:

http://gerrit.cloudera.org:8080/#/c/22610/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-orc.test@37
PS1, Line 37: Parquet
> Isn't it ORC in this case?
Done



--
To view, visit http://gerrit.cloudera.org:8080/22610
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1f1d0cf36792d0400de346c83e999fa50c0fa67
Gerrit-Change-Number: 22610
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Tue, 11 Mar 2025 15:38:11 +0000
Gerrit-HasComments: Yes

Reply via email to