Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/22447 )
Change subject: IMPALA-4017: support ANSI timestamp literal cast ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/22447/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22447/3//COMMIT_MSG@10 PS3, Line 10: Timestamp as literal similar to sql This change will also need automated tests added and documented here. For example, a new JUnit test for TimestampLiteral.java and also workload query tests (for example https://github.com/apache/impala/tree/master/testdata/workloads/functional-query). http://gerrit.cloudera.org:8080/#/c/22447/3/fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java File fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java: http://gerrit.cloudera.org:8080/#/c/22447/3/fe/src/main/java/org/apache/impala/analysis/TimestampLiteral.java@44 PS3, Line 44: public class TimestampLiteral extends LiteralExpr { This file has several compilation errors preventing it from compiling. -- To view, visit http://gerrit.cloudera.org:8080/22447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibcfd219c0a3192b2e2ea9a9363636f6194df8174 Gerrit-Change-Number: 22447 Gerrit-PatchSet: 3 Gerrit-Owner: Anshula Jain <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Fri, 14 Mar 2025 16:59:52 +0000 Gerrit-HasComments: Yes
