Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22588 )
Change subject: IMPALA-13812: Fail query for certain errors related to AI functions ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22588/4/be/src/exprs/ai-functions.cc File be/src/exprs/ai-functions.cc: http://gerrit.cloudera.org:8080/#/c/22588/4/be/src/exprs/ai-functions.cc@262 PS4, Line 262: // Return a string with the invalid prompt error message instead of failing > I think this should be a SQL error because prompt is added by the user and I was thinking a case that the prompt is passed from the resultset of a query on certain tables, and some rows might be empty. Would it be too strict to fail the whole query just because of some empty rows? -- To view, visit http://gerrit.cloudera.org:8080/22588 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I639e48e64d62f7990cf9a3c35a59a0ee3a2c64e0 Gerrit-Change-Number: 22588 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Mon, 10 Mar 2025 21:43:55 +0000 Gerrit-HasComments: Yes
