Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10512 )
Change subject: IMPALA-7012: Fix NPE when parsing unexpected tokens ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/10512/1/fe/src/main/jflex/sql-scanner.flex File fe/src/main/jflex/sql-scanner.flex: http://gerrit.cloudera.org:8080/#/c/10512/1/fe/src/main/jflex/sql-scanner.flex@300 PS1, Line 300: How about we assert here that size(tokenIdMap) == SqlParserSymbols.getFields().length so that someone does not unintentionally break this? http://gerrit.cloudera.org:8080/#/c/10512/1/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java File fe/src/test/java/org/apache/impala/common/FrontendTestBase.java: http://gerrit.cloudera.org:8080/#/c/10512/1/fe/src/test/java/org/apache/impala/common/FrontendTestBase.java@90 PS1, Line 90: new String[] { "-- +", "\n" }, // eol commented hint Just curious, why this change? -- To view, visit http://gerrit.cloudera.org:8080/10512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c846fdfb22ba37bfc3b1985b9a044014ab58968 Gerrit-Change-Number: 10512 Gerrit-PatchSet: 1 Gerrit-Owner: Tianyi Wang <tw...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Comment-Date: Wed, 30 May 2018 05:39:50 +0000 Gerrit-HasComments: Yes
