Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/22626 )
Change subject: IMPALA-13864: Implement ImpylaHS2ResultSet.exec_summary ...................................................................... Patch Set 9: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/22626/9/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/22626/9/shell/impala_client.py@533 PS9, Line 533: from exec_summary import build_exec_summary_table Why not import it at the beginning of the file? Doing it in the functions means that if it can't be imported for some reason then we'll only learn this when running the function. -- To view, visit http://gerrit.cloudera.org:8080/22626 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7d88f78e58eeda29ce21e7828884c7a129d7efe6 Gerrit-Change-Number: 22626 Gerrit-PatchSet: 9 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 24 Mar 2025 16:17:34 +0000 Gerrit-HasComments: Yes
