Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/22583 )
Change subject: IMPALA-13825: Extend Docker container build to custom base images ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/22583/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22583/5//COMMIT_MSG@59 PS5, Line 59: > nit: double space Added an explanation to the commit message. http://gerrit.cloudera.org:8080/#/c/22583/5/docker/daemon_entrypoint.sh File docker/daemon_entrypoint.sh: http://gerrit.cloudera.org:8080/#/c/22583/5/docker/daemon_entrypoint.sh@88 PS5, Line 88: elif [[ $DISTRIBUTION == Chainguard ]]; then > nit: this logic could probably be shared with Ubuntu. But not a big deal. I'd prefer to keep it separate for now: I think it's a bit more readable this way, and I am not sure that similarity between Ubuntu and Wolfi (which is mostly, but not completely based on Alpine) is a conscious design choice. Keeping the variants separate feels more maintainable to me (and future breaks perhaps more easily discoverable), but I don't feel to strongly about it either. http://gerrit.cloudera.org:8080/#/c/22583/5/docker/setup_build_context.py File docker/setup_build_context.py: http://gerrit.cloudera.org:8080/#/c/22583/5/docker/setup_build_context.py@182 PS5, Line 182: # Add script for installing Bash: Impala scripts need it, but some minimal base images > This comment seems like it should differ from line 186, mention bash in par Done -- To view, visit http://gerrit.cloudera.org:8080/22583 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia5e39f399664fe66f3774caa316ed5d4df24befc Gerrit-Change-Number: 22583 Gerrit-PatchSet: 6 Gerrit-Owner: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 24 Mar 2025 17:55:23 +0000 Gerrit-HasComments: Yes
