Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22319 )
Change subject: IMPALA-13657: Connect Calcite planner to Impala Frontend framework ...................................................................... Patch Set 18: (3 comments) http://gerrit.cloudera.org:8080/#/c/22319/24/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22319/24/fe/src/main/java/org/apache/impala/service/Frontend.java@2342 PS24, Line 2342: > Nit: I think we should use the Parser.parse() signature that also passes in Done http://gerrit.cloudera.org:8080/#/c/22319/18/tests/query_test/test_calcite_planner.py File tests/query_test/test_calcite_planner.py: http://gerrit.cloudera.org:8080/#/c/22319/18/tests/query_test/test_calcite_planner.py@29 PS18, Line 29: class TestCalcitePlanner(ImpalaTestSuite): > Let's keep this as a custom cluster test until we fix running Calcite tests Done http://gerrit.cloudera.org:8080/#/c/22319/18/tests/query_test/test_calcite_planner.py@43 PS18, Line 43: @pytest.mark.execute_serially > Leaving this for now until the above question is answered since I'm not sur Done -- To view, visit http://gerrit.cloudera.org:8080/22319 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3b30571beb797ede827ef4d794b8daefb130ccb1 Gerrit-Change-Number: 22319 Gerrit-PatchSet: 18 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 26 Mar 2025 14:55:35 +0000 Gerrit-HasComments: Yes
