Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22245 )
Change subject: IMPALA-13624: Implement textual representation for aggregate event sequences ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/22245/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22245/4//COMMIT_MSG@36 PS4, Line 36: | O . . . O | : | 8 - - - 4 | I don't immediately understand what this diagram means. For text, perhaps just printing percentile is sufficient, like this: https://github.com/apache/impala/blob/8101b0784ccd1b87b85c1a055e92866614eb36a8/be/src/util/runtime-profile.cc#L2306-L2347 -- To view, visit http://gerrit.cloudera.org:8080/22245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4bcc0e2e7fccfa8a184cfa8a3a96d68bfe6035c0 Gerrit-Change-Number: 22245 Gerrit-PatchSet: 4 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 26 Mar 2025 16:04:58 +0000 Gerrit-HasComments: Yes
