Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/22571 )
Change subject: IMPALA-13684: Improve waitForHmsEvent() to only wait for related events ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/22571/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java: http://gerrit.cloudera.org:8080/#/c/22571/8/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@1747 PS8, Line 1747: || MetastoreEvents.AbortTxnEvent.EVENT_TYPE.equals(e.getEventType()); Should we also consider commit_compaction event (because it can be generated by background threads)? http://gerrit.cloudera.org:8080/#/c/22571/8/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/22571/8/fe/src/main/java/org/apache/impala/service/Frontend.java@2244 PS8, Line 2244: Collection Why do we need to change this from Set? ParseTree/stmt can have table names multiple times right? http://gerrit.cloudera.org:8080/#/c/22571/8/fe/src/main/java/org/apache/impala/service/Frontend.java@2250 PS8, Line 2250: !(stmt instanceof CreateTableAsSelectStmt) : && !(stmt instanceof CreateTableLikeStmt) Do we need check for these 2 conditions? Because CreateTableAsSelectStmt and CreateTableLikeStmt are not instances of SingleTableStmt anyway. -- To view, visit http://gerrit.cloudera.org:8080/22571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic033b7e197cd19505653c3ff80c4857cc474bcfc Gerrit-Change-Number: 22571 Gerrit-PatchSet: 8 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Fri, 28 Mar 2025 04:52:27 +0000 Gerrit-HasComments: Yes
