Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/20169 )
Change subject: IMPALA-11980 (part 1): Put all thrift-generated python code into the impala_thrift_gen package ...................................................................... Patch Set 12: > Patch Set 12: Code-Review+1 > > Might be good idea to sort the import order. But don't mind if not, > considering the change size. isort seems useful, but might be too aggressive for us. https://pycqa.github.io/isort/docs/configuration/profiles.html This works for me: git show HEAD --name-only | grep 'tests.*py' \ | xargs -I {} isort --profile attrs --line-width 90 {} -- To view, visit http://gerrit.cloudera.org:8080/20169 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie2927f22c7257aa38a78084efe5bd76d566493c0 Gerrit-Change-Number: 20169 Gerrit-PatchSet: 12 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Tue, 01 Apr 2025 00:29:12 +0000 Gerrit-HasComments: No
