Hello Daniel Becker, Csaba Ringhofer, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22721
to look at the new patch set (#3).
Change subject: IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
......................................................................
IMPALA-13927: Fix crash on invalid BINARY data in TEXT tables
BINARY data in text files are expected to be Base64 encoded.
TextConverter::WriteSlot has a bug when it decodes base64 code,
it does not set the NULL-indicator bit to NULL for the slots of
the invalid BINARY values. Therefore later Tuple::CopyStrings can
try to copy invalid StringValue objects.
This patch fixes TextConverter::WriteSlot to set the NULL-indicator
bit in case of Base64 parse errors.
Testing
* e2e test added
Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
---
M be/src/exec/text-converter.inline.h
M bin/rat_exclude_files.txt
M testdata/data/README
A testdata/data/invalid_binary_data.txt
A testdata/workloads/functional-query/queries/QueryTest/invalid-binary-type.test
M tests/data_errors/test_data_errors.py
6 files changed, 98 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/21/22721/3
--
To view, visit http://gerrit.cloudera.org:8080/22721
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I79b712e2abe8ce6ecfbce508fd9e4e93fd63c964
Gerrit-Change-Number: 22721
Gerrit-PatchSet: 3
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
