Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22734 )
Change subject: WIP IMPALA-10268: Validate the debug actions when they are set ...................................................................... Patch Set 1: (28 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22734/1/be/src/runtime/debug-options.cc File be/src/runtime/debug-options.cc: http://gerrit.cloudera.org:8080/#/c/22734/1/be/src/runtime/debug-options.cc@40 PS1, Line 40: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py File tests/query_test/test_debug_action.py: http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@31 PS1, Line 31: ' flake8: E131 continuation line unaligned for hanging indent http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@38 PS1, Line 38: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@38 PS1, Line 38: 'RECVR_ADD_BATCH:JITTER@8@8': line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@40 PS1, Line 40: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@40 PS1, Line 40: 'RECVR_ADD_BATCH:FAIL@8': line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@42 PS1, Line 42: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@42 PS1, Line 42: 'RECVR_ADD_BATCH:EXCEPTION@Unknown': line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@46 PS1, Line 46: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@46 PS1, Line 46: '0:GETNEXT:DELAY@aa': line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@50 PS1, Line 50: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@50 PS1, Line 50: 'RECVR_ADD_BATCH:[email protected]|0:GETNEXT:FAIL': line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@54 PS1, Line 54: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@54 PS1, Line 54: '0:GETNEXT:FAIL|RECVR_ADD_BATCH:[email protected]': line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@58 PS1, Line 58: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@58 PS1, Line 58: 'RECVR_ADD_BATCH:FAIL@8|0:GETNEXT:FAIL': line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@62 PS1, Line 62: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@62 PS1, Line 62: '0:GETNEXT:FAIL|RECVR_ADD_BATCH:FAIL@8': line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@66 PS1, Line 66: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@66 PS1, Line 66: 'RECVR_ADD_BATCH:[email protected]|0:GETNEXT:DELAY@aa': line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@70 PS1, Line 70: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@70 PS1, Line 70: '0:GETNEXT:DELAY@aa|RECVR_ADD_BATCH:[email protected]': line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@72 PS1, Line 72: flake8: W293 blank line contains whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@72 PS1, Line 72: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@74 PS1, Line 74: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@74 PS1, Line 74: 'RECVR_ADD_BATCH:FAIL@8|0:GETNEXT:DELAY@aa': line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@78 PS1, Line 78: flake8: W291 trailing whitespace http://gerrit.cloudera.org:8080/#/c/22734/1/tests/query_test/test_debug_action.py@78 PS1, Line 78: '0:GETNEXT:DELAY@aa|RECVR_ADD_BATCH:FAIL@8': line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/22734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53816aba2c79b556688d3b916883fee7476fdbb5 Gerrit-Change-Number: 22734 Gerrit-PatchSet: 1 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 04 Apr 2025 14:27:21 +0000 Gerrit-HasComments: Yes
