Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22371 )
Change subject: IMPALA-13660: Support caching broadcast hash joins ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/22371/7/be/src/exec/join-builder.cc File be/src/exec/join-builder.cc: http://gerrit.cloudera.org:8080/#/c/22371/7/be/src/exec/join-builder.cc@91 PS7, Line 91: if (no_threads_remaining) build_wakeup_cv_.NotifyAll(); > Is build_wakeup_cv_ guaranteed to be locked here? The separate_build_lock_ synchronizes access to outstanding_probes_ and probe_refcount_ and is the mutex used for build_wakeup_cv_. When the code waiting on build_wakeup_cv_ in JoinBuilder::HandoffToProbesAndWait() checks for outstanding_probes_ == 0 and probe_refcount_ == 0, it is holding that mutex. We don't hold separate_build_lock_ while notifying so that the notified thread can get the mutex immediately. -- To view, visit http://gerrit.cloudera.org:8080/22371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic61462702b43175c593b34e8c3a14b9cfe85c29e Gerrit-Change-Number: 22371 Gerrit-PatchSet: 7 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Tue, 08 Apr 2025 17:58:40 +0000 Gerrit-HasComments: Yes
