Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21031 )

Change subject: IMPALA-12709: Add support for hierarchical metastore event 
processing
......................................................................


Patch Set 40:

(5 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/21031/40/tests/custom_cluster/test_event_processing_perf.py
File tests/custom_cluster/test_event_processing_perf.py:

http://gerrit.cloudera.org:8080/#/c/21031/40/tests/custom_cluster/test_event_processing_perf.py@35
PS40, Line 35: \
flake8: E502 the backslash is redundant between brackets


http://gerrit.cloudera.org:8080/#/c/21031/40/tests/custom_cluster/test_event_processing_perf.py@261
PS40, Line 261: c
flake8: E306 expected 1 blank line before a nested definition, found 0


http://gerrit.cloudera.org:8080/#/c/21031/40/tests/custom_cluster/test_event_processing_perf.py@277
PS40, Line 277: e
flake8: U100 Unused argument 'exc_type'


http://gerrit.cloudera.org:8080/#/c/21031/40/tests/custom_cluster/test_event_processing_perf.py@277
PS40, Line 277: e
flake8: U100 Unused argument 'exc_val'


http://gerrit.cloudera.org:8080/#/c/21031/40/tests/custom_cluster/test_event_processing_perf.py@277
PS40, Line 277: e
flake8: U100 Unused argument 'exc_tb'



--
To view, visit http://gerrit.cloudera.org:8080/21031
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6
Gerrit-Change-Number: 21031
Gerrit-PatchSet: 40
Gerrit-Owner: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Anonymous Coward <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Thu, 10 Apr 2025 10:29:00 +0000
Gerrit-HasComments: Yes

Reply via email to