gaurav singh has posted comments on this change. ( http://gerrit.cloudera.org:8080/22424 )
Change subject: IMPALA-13675: OAuth AuthN Support for Impala Shell ...................................................................... Patch Set 22: (4 comments) http://gerrit.cloudera.org:8080/#/c/22424/21/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/22424/21/shell/impala_shell.py@1000 PS21, Line 1000: if self.use_oauth and self.oauth is None: > The do_connection function was already 202 lines line before adding this OA Done http://gerrit.cloudera.org:8080/#/c/22424/21/shell/impala_shell.py@1019 PS21, Line 1019: TP_PORT) > Needs to be switched to using new client id parameter. Done http://gerrit.cloudera.org:8080/#/c/22424/16/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22424/16/tests/custom_cluster/test_shell_jwt_auth.py@207 PS16, Line 207: size=1) > It will error now that the client-id parameter is being used. Thus --clien Done http://gerrit.cloudera.org:8080/#/c/22424/21/tests/custom_cluster/test_shell_jwt_auth.py File tests/custom_cluster/test_shell_jwt_auth.py: http://gerrit.cloudera.org:8080/#/c/22424/21/tests/custom_cluster/test_shell_jwt_auth.py@213 PS21, Line 213: oauth-tes > Let's use a different value here since "test-user" is the subject of the te Done -- To view, visit http://gerrit.cloudera.org:8080/22424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I84e26d54f6a53696660728efb239ffd43de4c55d Gerrit-Change-Number: 22424 Gerrit-PatchSet: 22 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 10 Apr 2025 21:21:19 +0000 Gerrit-HasComments: Yes
