Thomas Marshall has posted comments on this change. ( http://gerrit.cloudera.org:8080/10466 )
Change subject: IMPALA-6947: Kudu tests flaky due to rpc timeout ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/10466/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10466/1//COMMIT_MSG@18 PS1, Line 18: Testing: : - Passed a full run of core tests > Also, since this affects ASAN, I suggest trying this against an ASAN build. Done http://gerrit.cloudera.org:8080/#/c/10466/1/be/src/common/global-flags.cc File be/src/common/global-flags.cc: http://gerrit.cloudera.org:8080/#/c/10466/1/be/src/common/global-flags.cc@162 PS1, Line 162: // Timeout (ms) for Kudu rpcs set in the BE on the KuduClient. : DEFINE_int32(kudu_rpc_timeout_ms, 0, "(Advanced) Timeout (milliseconds) set for " : "individual Kudu rpcs. An operation may consist of several rpcs, so this is expected " : > Is this an option that ought to be hidden away from users/customers? If yes I don't think it needs to be hidden, a real user could conceivably use it, but I marked it Advanced. http://gerrit.cloudera.org:8080/#/c/10466/1/bin/run-all-tests.sh File bin/run-all-tests.sh: http://gerrit.cloudera.org:8080/#/c/10466/1/bin/run-all-tests.sh@84 PS1, Line 84: : ${CODE_COVERAGE:=false} > Since this only happens with Kudu on ASAN, I think we only want to enable t Done -- To view, visit http://gerrit.cloudera.org:8080/10466 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c4a2d87934cd4eb98509512f7060a596894ed53 Gerrit-Change-Number: 10466 Gerrit-PatchSet: 2 Gerrit-Owner: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Thomas Marshall <thomasmarsh...@cmu.edu> Gerrit-Comment-Date: Thu, 31 May 2018 23:13:55 +0000 Gerrit-HasComments: Yes
