Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22634 )
Change subject: IMPALA-13850 (part 1): Wait until CatalogD active before resetting ...................................................................... Patch Set 16: (3 comments) http://gerrit.cloudera.org:8080/#/c/22634/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22634/15//COMMIT_MSG@24 PS15, Line 24: : The later prerequisite is to ensure that all coordinators are not : blocked waiting for full topic update in on-demand metadata mode. This : is all manage > LGTM. Do we have test coverage for this? I.e. if we don't restore it in pat It will show up later in part 2. Check out https://gerrit.cloudera.org/c/22640/18..19 Without patch set 16 adjustment, we'll need extra sleep if CatalogD is in legacy mode, because full-topic update is only sent at second update (the first only contain newly regenerated CatalogD service id). http://gerrit.cloudera.org:8080/#/c/22634/16/be/src/catalog/catalog-server.cc File be/src/catalog/catalog-server.cc: http://gerrit.cloudera.org:8080/#/c/22634/16/be/src/catalog/catalog-server.cc@717 PS16, Line 717: if (FLAGS_catalogd_ha_reset_metadata_on_failover) { : triggered_first_reset_ = false; : } > Can we move this below to L724, or it should be done before regenerating th Should be OK. catalog_lock_ is held above. Will do. http://gerrit.cloudera.org:8080/#/c/22634/16/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/22634/16/tests/common/impala_cluster.py@566 PS16, Line 566: # noqa: U100 > Why do we need this "noqa" comment? Without this annotation, flake8 complain that self, class_name, and level parameters are unused. But they are actually being used by the subclasses of BaseImpalaProcess. -- To view, visit http://gerrit.cloudera.org:8080/22634 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I58cc66dcccedb306ff11893f2916ee5ee6a3efc1 Gerrit-Change-Number: 22634 Gerrit-PatchSet: 16 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 15 Apr 2025 13:51:17 +0000 Gerrit-HasComments: Yes
