Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22785 )
Change subject: IMPALA-13970: Add NaN and Infinity parsing in ImpylaHS2ResultSet ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22785/1/tests/query_test/test_queries.py File tests/query_test/test_queries.py: http://gerrit.cloudera.org:8080/#/c/22785/1/tests/query_test/test_queries.py@268 PS1, Line 268: def default_test_protocol(cls): > This override was added in the parent patch. Can we remove it completely? This override is intended to proof that NaN, Infinity, and boolean parsing in ImpylaHS2ResultSet works. This is the first time we validate such parsing. -- To view, visit http://gerrit.cloudera.org:8080/22785 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I739a88e9dfa418d3a3c2d9d4181b4add34bc6b93 Gerrit-Change-Number: 22785 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Comment-Date: Wed, 16 Apr 2025 23:03:12 +0000 Gerrit-HasComments: Yes
