Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22706 )
Change subject: IMPALA-12427: Documentation for Workload Management ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/22706/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22706/8//COMMIT_MSG@9 PS8, Line 9: This change adds documentation for the Workload management feature. nit: management is capitalized most other places. http://gerrit.cloudera.org:8080/#/c/22706/8/docs/topics/impala_workload_mgmt.xml File docs/topics/impala_workload_mgmt.xml: http://gerrit.cloudera.org:8080/#/c/22706/8/docs/topics/impala_workload_mgmt.xml@73 PS8, Line 73: startup flag or maximum queued <codeph>query_log_max_queued</codeph> flag, the I'm not sure "maximum queued" provides any additional clarity on "query_log_max_queued". The flag description later on seems sufficient. http://gerrit.cloudera.org:8080/#/c/22706/8/docs/topics/impala_workload_mgmt.xml@75 PS8, Line 75: to the Apache Iceberg table <codeph>sys.impala_query_log</codeph>. This table is I'd suggest also discussing graceful shutdown behavior, where it tries to write out the queue before shutdown independent of these parameters. http://gerrit.cloudera.org:8080/#/c/22706/8/docs/topics/impala_workload_mgmt.xml@85 PS8, Line 85: You can query both tables like any other table in Impala—simply use any SQL client. "simply" is generally avoided in technical docs. I'd consider removing this sentence altogether - I think it's obvious - or phrase it > You can query both tables like any other table in Impala using an SQL client. I'd also move this above the previous paragraph, as it's more related to how the table is stored, which also groups the two paragraphs about "telemetry move". http://gerrit.cloudera.org:8080/#/c/22706/8/docs/topics/impala_workload_mgmt.xml@135 PS8, Line 135: <tbody> Do we have a way to automatically generate this table? http://gerrit.cloudera.org:8080/#/c/22706/8/docs/topics/impala_workload_mgmt.xml@612 PS8, Line 612: Workload management is configured by startup flags on all coordinator processes. It also needs to be enabled on catalogd, so that the `sys` database and table definitions are visible. -- To view, visit http://gerrit.cloudera.org:8080/22706 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c228dfaa3f6060add6e5bd8058551a4d362f460 Gerrit-Change-Number: 22706 Gerrit-PatchSet: 8 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 16 Apr 2025 23:49:25 +0000 Gerrit-HasComments: Yes
