Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/22734 )
Change subject: IMPALA-10268: Validate the debug actions when they are set ...................................................................... Patch Set 8: Code-Review+1 (4 comments) LGTM, some minor comments http://gerrit.cloudera.org:8080/#/c/22734/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22734/8//COMMIT_MSG@25 PS8, Line 25: sparsed nit. Not sure what "sparsed" means here, using a simpler word might help make it clearer http://gerrit.cloudera.org:8080/#/c/22734/8/be/src/exec/exec-node.cc File be/src/exec/exec-node.cc: http://gerrit.cloudera.org:8080/#/c/22734/8/be/src/exec/exec-node.cc@476 PS8, Line 476: if (!param.empty()) { Maybe better adding DCHECK(sleep_duration_ms != nullptr) http://gerrit.cloudera.org:8080/#/c/22734/8/be/src/service/query-options.cc File be/src/service/query-options.cc: http://gerrit.cloudera.org:8080/#/c/22734/8/be/src/service/query-options.cc@316 PS8, Line 316: // Verify General DebugAction's first. In case it passes or 'invalid command' : // verify ExecNode DebugAction's. Maybe clarify this comment a bit. Like, "Verify General DebugAction's first. If it's valid or just an 'invalid command', continue with ExecNode validation." http://gerrit.cloudera.org:8080/#/c/22734/8/be/src/service/query-options.cc@316 PS8, Line 316: // Verify General DebugAction's first. In case it passes or 'invalid command' : // verify ExecNode DebugAction's. 'invalid command' might indicate an ExecNode DebugAction? Might be worth adding a brief comment to explain the rationale, if this is expected behavior -- To view, visit http://gerrit.cloudera.org:8080/22734 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I53816aba2c79b556688d3b916883fee7476fdbb5 Gerrit-Change-Number: 22734 Gerrit-PatchSet: 8 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 23 Apr 2025 23:04:36 +0000 Gerrit-HasComments: Yes
