Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10575 )
Change subject: IMPALA-7109: fix test_multiple_partitions_same_location paths ...................................................................... Patch Set 1: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/10575/1/tests/metadata/test_partition_metadata.py File tests/metadata/test_partition_metadata.py: http://gerrit.cloudera.org:8080/#/c/10575/1/tests/metadata/test_partition_metadata.py@52 PS1, Line 52: qualified_path > What does the qualified_path skip marker mean then, if not that we can't us I think it was originally added for tests that explicitly used locations like "hdfs://...", since those tests weren't expected to work on non HDFS filesystems. But I agree, it's probably a waste of time trying to get this working for local now. LGTM otherwise. -- To view, visit http://gerrit.cloudera.org:8080/10575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7fc0b2aa2e82bfd8224c52546683f23de20cb640 Gerrit-Change-Number: 10575 Gerrit-PatchSet: 1 Gerrit-Owner: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Jun 2018 17:50:51 +0000 Gerrit-HasComments: Yes
