Alex Rodoni has posted comments on this change. ( http://gerrit.cloudera.org:8080/10511 )
Change subject: IMPALA-5740: [DOCS] Correct the max length of STRING ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/10511/2/docs/topics/impala_string.xml File docs/topics/impala_string.xml: http://gerrit.cloudera.org:8080/#/c/10511/2/docs/topics/impala_string.xml@68 PS2, Line 68: The hard limit is 2 GB on <codeph>STRING</codeph>. > Maybe "The hard limit on the size of a STRING and the total size of a row i Done http://gerrit.cloudera.org:8080/#/c/10511/2/docs/topics/impala_string.xml@83 PS2, Line 83: will > Maybe "may". "will" is a little too scary maybe. Done http://gerrit.cloudera.org:8080/#/c/10511/2/docs/topics/impala_string.xml@88 PS2, Line 88: The row size, i.e. total size of all string and other columns, is : limited by various factors, such as: > I think this could be clearer (my fault for vague wording in the original J Done http://gerrit.cloudera.org:8080/#/c/10511/2/docs/topics/impala_string.xml@97 PS2, Line 97: spilling hash join > Not sure if we use "spilling" elsewere in docs. Maybe Done http://gerrit.cloudera.org:8080/#/c/10511/2/docs/topics/impala_string.xml@101 PS2, Line 101: Rows being sorted > maybe "being sorted by the "SORT" operator without a limit." Done http://gerrit.cloudera.org:8080/#/c/10511/2/docs/topics/impala_string.xml@112 PS2, Line 112: the row : size is 8 MB. > "of row size in the above places is 8MB", just to be clearer that it's tied Done -- To view, visit http://gerrit.cloudera.org:8080/10511 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I43c5a2819c8a3db33a8ce3a6bbde6a1d823ec9b2 Gerrit-Change-Number: 10511 Gerrit-PatchSet: 2 Gerrit-Owner: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Alex Rodoni <arod...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Fri, 01 Jun 2018 19:58:11 +0000 Gerrit-HasComments: Yes
