[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/21031 )
Change subject: IMPALA-12709: Add support for hierarchical metastore event processing ...................................................................... Patch Set 49: (3 comments) http://gerrit.cloudera.org:8080/#/c/21031/48/tests/custom_cluster/test_event_processing_perf.py File tests/custom_cluster/test_event_processing_perf.py: http://gerrit.cloudera.org:8080/#/c/21031/48/tests/custom_cluster/test_event_processing_perf.py@453 PS48, Line 453: if add_part_time is not None: > nit: This if..elif.. clause is a bit confusing. Can we simply use if is_par Have changed elif to if now to avoid confusion. http://gerrit.cloudera.org:8080/#/c/21031/48/tests/custom_cluster/test_event_processing_perf.py@488 PS48, Line 488: if not self.process_events_together: : return self.__process_events_now(start_event_id) : : def __ensure_events_processed(self): > nit: The if-checks is not that straightforward to understand. Maybe the cod Done http://gerrit.cloudera.org:8080/#/c/21031/48/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21031/48/tests/custom_cluster/test_events_custom_configs.py@1521 PS48, Line 1521: # Drop table t2, rename t1 to t2, load some data to t2 and create t1 from hive again > nit: can we pause EP here and resume it at L1528 to make sure all these eve Done -- To view, visit http://gerrit.cloudera.org:8080/21031 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I76d8a739f9db6d40f01028bfd786a85d83f9e5d6 Gerrit-Change-Number: 21031 Gerrit-PatchSet: 49 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 30 Apr 2025 03:10:50 +0000 Gerrit-HasComments: Yes
