Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22215 )
Change subject: IMPALA-13478: Sync tuple cache files to disk asynchronously ...................................................................... Patch Set 6: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/22215/6/be/src/runtime/tuple-cache-mgr.cc File be/src/runtime/tuple-cache-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22215/6/be/src/runtime/tuple-cache-mgr.cc@494 PS6, Line 494: ((new_size / outstanding_write_chunk_bytes_) + 1) * outstanding_write_chunk_bytes_; line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22215/6/be/src/runtime/tuple-cache-mgr.cc@660 PS6, Line 660: LOG(WARNING) << Substitute("SyncFileToDisk: Failed to sync file $0: $1", file_path, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/22215/6/be/src/runtime/tuple-cache-mgr.cc@667 PS6, Line 667: LOG(WARNING) << Substitute("SyncFileToDisk: Failed to close file $0: $1", file_path, line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/22215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I646bb56300656d8b8ac613cb8fe2f85180b386d3 Gerrit-Change-Number: 22215 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 01 May 2025 23:08:02 +0000 Gerrit-HasComments: Yes
