Surya Hebbar has posted comments on this change. ( http://gerrit.cloudera.org:8080/22718 )
Change subject: IMPALA-13923: Support more compression levels for ZSTD and ZLIB ...................................................................... Patch Set 10: (2 comments) The following tests were executed successfully now, to verify codecs and compression levels. - DecompressorTest.ZSTD* - DecompressorTest.Gzip - DecompressorTest.Bzip - QueryOptions.CompressionCodec - TestComputeStats::test_compute_stats_compression_codec Also, for the stored Parquet, manually verified the compression codec used for ZSTD and ZLIB. http://gerrit.cloudera.org:8080/#/c/22718/3/be/src/util/compress.h File be/src/util/compress.h: http://gerrit.cloudera.org:8080/#/c/22718/3/be/src/util/compress.h@48 PS3, Line 48: }; > One way to do this is to keep Codec::ValidateCompressionLevel() static and My initial implementation was similar to this. But, I had moved away from this, thinking, adding methods to base compression classes might be more verbose. But now, this seems to be the cleanest way. Thank you for the detailed comments. Done. http://gerrit.cloudera.org:8080/#/c/22718/9/be/src/util/parse-util.cc File be/src/util/parse-util.cc: http://gerrit.cloudera.org:8080/#/c/22718/9/be/src/util/parse-util.cc@151 PS9, Line 151: } Manual compression tests and compute_stats_compression_codec were failing due to returning from ParseCompressionCodec earlier, before setting *type later. Fixed. -- To view, visit http://gerrit.cloudera.org:8080/22718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5b98c735246f08e04598a4e752c8cca04e31a88a Gerrit-Change-Number: 22718 Gerrit-PatchSet: 10 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Mon, 05 May 2025 08:58:43 +0000 Gerrit-HasComments: Yes
