Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22852 )
Change subject: IMPALA-14027: Implement HS2 NULL_TYPE using TStringVal ...................................................................... Patch Set 1: (3 comments) Thanks Riza! http://gerrit.cloudera.org:8080/#/c/22852/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22852/1//COMMIT_MSG@7 PS1, Line 7: TStringVal Here it says TStringVal, on L9 it's TStringValue. It would be better to be consistent. http://gerrit.cloudera.org:8080/#/c/22852/1/fe/src/test/java/org/apache/impala/service/JdbcTest.java File fe/src/test/java/org/apache/impala/service/JdbcTest.java: http://gerrit.cloudera.org:8080/#/c/22852/1/fe/src/test/java/org/apache/impala/service/JdbcTest.java@604 PS1, Line 604: to be compatible with Hive Is this part of the sentence still valid? http://gerrit.cloudera.org:8080/#/c/22852/1/tests/hs2/test_fetch.py File tests/hs2/test_fetch.py: http://gerrit.cloudera.org:8080/#/c/22852/1/tests/hs2/test_fetch.py@245 PS1, Line 245: # Check that the expected type is boolean (for compatibility with Hive, see also This comment should be updated. -- To view, visit http://gerrit.cloudera.org:8080/22852 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I354110164b360013d9893f1eb4398c3418f80472 Gerrit-Change-Number: 22852 Gerrit-PatchSet: 1 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 05 May 2025 15:39:52 +0000 Gerrit-HasComments: Yes
