Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22844 )
Change subject: IMPALA-13850 (part 2): Stabilize test_restart_services.py ...................................................................... Patch Set 6: Code-Review+2 (2 comments) LGTM. Feel free to carry my +2. http://gerrit.cloudera.org:8080/#/c/22844/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22844/6//COMMIT_MSG@14 PS6, Line 14: There is a slight duration where : CatalogD accept getCatalogObject() request before the very first : CatalogServiceCatalog.reset() initiated and obtain write lock. nit: let's mention the result of this, i.e. the request might see an empty catalog which results in query failures of db/table not exists. http://gerrit.cloudera.org:8080/#/c/22844/6//COMMIT_MSG@18 PS6, Line 18: CatalogChangeMonitor nit: stale? -- To view, visit http://gerrit.cloudera.org:8080/22844 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I97f6f692506de0bbf2e1445f83bed824dc8298fd Gerrit-Change-Number: 22844 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Fri, 09 May 2025 13:21:10 +0000 Gerrit-HasComments: Yes
