Laszlo Gaal has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/22811 )

Change subject: IMPALA-13937: Use simpler chmod syntax to set +t on /var/tmp in 
Docker build
......................................................................

IMPALA-13937: Use simpler chmod syntax to set +t on /var/tmp in Docker build

Some Docker base images contain basic Unix utilities implemented by
Busybox instead of the usual linux-coreutils package. The chmod command
in the Busybox implementation seems to ignore certain syntax variants:
the current invocation for setting the sticky bit (+t) on /var/tmp got
silently ignored, while chmod indicated success, returning 0 to the
calling script.

This patch changes the chmod call to a slightly simple syntax, which was
tested to be understood by Busybox and coreutils both; and adds a simple
inline check to assert that the directories required by Kerberos
- exist
- and have the required ownership and permission structure.

The assertion fails the Docker build if setting up /tmp and /var/tmp in
a Kerberos-compatible way did not succeed.

Change-Id: I20c52dc70fb73337efcd6d12652bf99c3c473ff9
Reviewed-on: http://gerrit.cloudera.org:8080/22811
Reviewed-by: Peter Rozsa <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M docker/install_os_packages.sh
1 file changed, 5 insertions(+), 1 deletion(-)

Approvals:
  Peter Rozsa: Looks good to me, approved
  Impala Public Jenkins: Verified

--
To view, visit http://gerrit.cloudera.org:8080/22811
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I20c52dc70fb73337efcd6d12652bf99c3c473ff9
Gerrit-Change-Number: 22811
Gerrit-PatchSet: 3
Gerrit-Owner: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>
Gerrit-Reviewer: Peter Rozsa <[email protected]>

Reply via email to