Hello Zoltan Borok-Nagy, Wenzhe Zhou, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22896
to look at the new patch set (#2).
Change subject: IMPALA-14070: Use checkedMultiply in SortNode.java
......................................................................
IMPALA-14070: Use checkedMultiply in SortNode.java
maxRowsInHeaps calculation may overflow because it use simple
multiplication. This patch fix the bug by calculating it using
checkedMultiply(). A broader refactoring will be done by IMPALA-14071.
Testing:
Add ee tests TestTopNHighNdv that exercise the issue.
Change-Id: Ic6712b94f4704fd8016829b2538b1be22baaf2f7
---
M fe/src/main/java/org/apache/impala/planner/SortNode.java
A
testdata/workloads/functional-query/queries/QueryTest/partitioned-top-n-high-ndv.test
M tests/query_test/test_queries.py
3 files changed, 90 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/96/22896/2
--
To view, visit http://gerrit.cloudera.org:8080/22896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ic6712b94f4704fd8016829b2538b1be22baaf2f7
Gerrit-Change-Number: 22896
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
