Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22857 )
Change subject: IMPALA-14032: Fix broken query timeline after webUI refactor in IMPALA-13389 ...................................................................... Patch Set 2: > Patch Set 2: > > The job now verifies changes based on JS tests and adds a verified label +1. > > I have removed the the submit functionality from the gerrit-verify-webui job, > so only once with access can submit it. > > This fast and efficient job is helpful to quickly test patches instead of > gerrit-verify-dryrun. > > I have noted in the job as well as gerrit message, that this is to be used > only for .js changes not .tmpl or any other changes. > > Please help submit the patch, if you feel this is correct. Hi Surya, I think https://jenkins.impala.io/job/gerrit-verify-webui/ must not apply Verified +1 vote. I'm OK for having it just for DRY RUN, but Verified +1 should only given through https://jenkins.impala.io/job/gerrit-verify-dryrun/. Once a patch get Verified +1 vote, it is eligible for submission by any committer. If they don't pay attention, they will not realize that only JS test has been done, not the full precommit tests. -- To view, visit http://gerrit.cloudera.org:8080/22857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I49a3e5405588edd07836605bff2efc00b9fa3ee9 Gerrit-Change-Number: 22857 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <sheb...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Surya Hebbar <sheb...@cloudera.com> Gerrit-Comment-Date: Wed, 14 May 2025 15:10:59 +0000 Gerrit-HasComments: No
