Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21514 )
Change subject: IMPALA-13235: Add OpenTelemetry C++ ...................................................................... Patch Set 9: (1 comment) http://gerrit.cloudera.org:8080/#/c/21514/7/source/opentelemetry-cpp/build.sh File source/opentelemetry-cpp/build.sh: http://gerrit.cloudera.org:8080/#/c/21514/7/source/opentelemetry-cpp/build.sh@36 PS7, Line 36: -DWITH_OTLP_GRPC=OFF \ > Do we need gRPC support? We don't use it. And we don't have a build of gRPC gRPC is a little faster than HTTP, thus I was hoping to offer it along with HTTP. However, I ran into lots of issues building locally when gRPC was a dependency. I'll remove it for now and we can revisit later if necessary. -- To view, visit http://gerrit.cloudera.org:8080/21514 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: native-toolchain Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1657e2d344e90654b5d009d65973d762c0081a05 Gerrit-Change-Number: 21514 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Thu, 15 May 2025 23:23:37 +0000 Gerrit-HasComments: Yes
