Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10596 )
Change subject: IMPALA-6910/IMPALA-7070: Increase log level for HDFS S3 code ...................................................................... Patch Set 2: > Surely, we're not shipping fe/src/test/resources, so it doesn't > matter vis-a-vis releases? I didn't double-check that, but we > should have a way to specify log4j for our tests independently of > what we recommend in clusters. +1 to Phil's comment, it can help with testing a lot of Hadoop features that aren't enabled by default. Sharing Lars' sentiment, I've spent quite a lot of time trying to repro a different flaky S3 failure too, with no avail. This will definitely help catch the bug(s) when it happens on a nightly run. But we should also make sure that we turn it off later. -- To view, visit http://gerrit.cloudera.org:8080/10596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If5f9650a322f9c987f5f4e322681ab290cf487ee Gerrit-Change-Number: 10596 Gerrit-PatchSet: 2 Gerrit-Owner: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Comment-Date: Tue, 05 Jun 2018 16:08:24 +0000 Gerrit-HasComments: No
