Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/22554 )
Change subject: IMPALA-13593: Enable event processor to consume ALTER_PARTITIONS events from metastore ...................................................................... Patch Set 3: (8 comments) http://gerrit.cloudera.org:8080/#/c/22554/3/bin/impala-config.sh File bin/impala-config.sh: http://gerrit.cloudera.org:8080/#/c/22554/3/bin/impala-config.sh@239 PS3, Line 239: 7.3.1.200-2 Can we use a newer version like 7.3.1.200-90? I recently hit the bug fixed by HIVE-28545 and hope that we can fix it with this version bump. A newer version can avoid hitting other bugs. http://gerrit.cloudera.org:8080/#/c/22554/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java: http://gerrit.cloudera.org:8080/#/c/22554/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@51 PS3, Line 51: import org.apache.hadoop.hive.metastore.messaging.AlterPartitionsMessage; Is this a problem when building on Apache Hive 3? We probably need to wrap the usage on it into a new method in fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java http://gerrit.cloudera.org:8080/#/c/22554/3/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java@2888 PS3, Line 2888: ALTER_PARTITIONS EVENT nit: use getEventDesc() to also show the event id. http://gerrit.cloudera.org:8080/#/c/22554/3/fe/src/test/resources/hive-site.xml.py File fe/src/test/resources/hive-site.xml.py: http://gerrit.cloudera.org:8080/#/c/22554/3/fe/src/test/resources/hive-site.xml.py@98 PS3, Line 98: nit: use 2 spaces indention http://gerrit.cloudera.org:8080/#/c/22554/3/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/22554/3/tests/custom_cluster/test_events_custom_configs.py@1671 PS3, Line 1671: event_found = True nit: add an else-clause to log the event to ease debug in the future. else: logging.info("Found " + str(event)) http://gerrit.cloudera.org:8080/#/c/22554/3/tests/custom_cluster/test_events_custom_configs.py@1676 PS3, Line 1676: # self.client.execute(":event_processor('pause')") stale comment http://gerrit.cloudera.org:8080/#/c/22554/3/tests/custom_cluster/test_events_custom_configs.py@1679 PS3, Line 1679: # self.client.execute(":event_processor('start')") stale comment http://gerrit.cloudera.org:8080/#/c/22554/3/tests/custom_cluster/test_events_custom_configs.py@1686 PS3, Line 1686: event_found = True nit: Also add an else-clause here to log the event -- To view, visit http://gerrit.cloudera.org:8080/22554 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I009a87ef5e2c331272f9e2d7a6342cc860e64737 Gerrit-Change-Number: 22554 Gerrit-PatchSet: 3 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Mon, 19 May 2025 09:50:41 +0000 Gerrit-HasComments: Yes
