Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22861 )
Change subject: IMPALA-14031: Enable keepalive by default for client connections ...................................................................... Patch Set 1: > In test_client_keepalive.py, should we remove KEEPALIVE_ARGS from > impalad_args? After looking at this a bit, the test depends on that specific value of 600, as it is parsing the keepalive timers and verifying the time value. I think I would rather leave it specified in the test itself so that it doesn't depend on the default value. -- To view, visit http://gerrit.cloudera.org:8080/22861 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie358b5cabaff884516f7117d20d18c25124e59d5 Gerrit-Change-Number: 22861 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 19 May 2025 17:32:17 +0000 Gerrit-HasComments: No
