Dan Hecht has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10601 )

Change subject: IMPALA-7101: Fix race between Fetch and Close RPCs that can 
lead to hang
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10601/3/tests/query_test/test_cancellation.py
File tests/query_test/test_cancellation.py:

http://gerrit.cloudera.org:8080/#/c/10601/3/tests/query_test/test_cancellation.py@230
PS3, Line 230: TestCancellatio
that should be TestCancellationFullSort (otherwise the super method is not 
called, which leads to the dimensions that aren't being overrided not being 
added).



--
To view, visit http://gerrit.cloudera.org:8080/10601
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c147550f86d81b818ecbdd34cf2919ced7ff8c5
Gerrit-Change-Number: 10601
Gerrit-PatchSet: 3
Gerrit-Owner: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Jun 2018 16:22:04 +0000
Gerrit-HasComments: Yes

Reply via email to