Joe McDonnell has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22906 )

Change subject: IMPALA-14067: Bump glog version to 0.6.0 in Impala
......................................................................


Patch Set 5: Code-Review+1

(1 comment)

This is looking good to me.

http://gerrit.cloudera.org:8080/#/c/22906/5/bin/impala-config.sh
File bin/impala-config.sh:

http://gerrit.cloudera.org:8080/#/c/22906/5/bin/impala-config.sh@84
PS5, Line 84: export IMPALA_TOOLCHAIN_BUILD_ID_AARCH64=88-9e13c76e2b
            : export IMPALA_TOOLCHAIN_BUILD_ID_X86_64=522-9e13c76e2b
            : export IMPALA_TOOLCHAIN_REPO=\
            : 
${IMPALA_TOOLCHAIN_REPO:-https://github.com/cloudera/native-toolchain.git}
            : export IMPALA_TOOLCHAIN_BRANCH=${IMPALA_TOOLCHAIN_BRANCH:-master}
            : export IMPALA_TOOLCHAIN_COMMIT_HASH=\
            : 
${IMPALA_TOOLCHAIN_COMMIT_HASH-9e13c76e2b5b699e16c4172416de35a423b75348}
I merged the toolchain change and started builds. It is nice if the commit hash 
that we put here corresponds to a commit in the cloudera/native-toolchain repo. 
So, when the build is done, let's pick that up.



--
To view, visit http://gerrit.cloudera.org:8080/22906
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ifbe341265fd7aa7be8fe304b9fda31b4470237cf
Gerrit-Change-Number: 22906
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Becker <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 21 May 2025 05:22:00 +0000
Gerrit-HasComments: Yes

Reply via email to