Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/22215 )
Change subject: IMPALA-13478: Sync tuple cache files to disk asynchronously ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/22215/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22215/8//COMMIT_MSG@44 PS8, Line 44: - number of syncs calls that fail (due to IO errors) > nit: this line pluralizes sync, the next line doesn't. Seems inconsistent. Done http://gerrit.cloudera.org:8080/#/c/22215/8/be/src/runtime/tuple-cache-mgr-test.cc File be/src/runtime/tuple-cache-mgr-test.cc: http://gerrit.cloudera.org:8080/#/c/22215/8/be/src/runtime/tuple-cache-mgr-test.cc@376 PS8, Line 376: TestOutstandingWriteLimit > Is there an existing test that covers concurrent writes when the outstandin Not really, I'll add a unit test here with concurrency. I don't think we have much else. http://gerrit.cloudera.org:8080/#/c/22215/8/be/src/runtime/tuple-cache-mgr-test.cc@474 PS8, Line 474: TestSyncToDisk > Can we add a test that a small tuple_cache_sync_pool_queue_depth to trigger Done http://gerrit.cloudera.org:8080/#/c/22215/8/be/src/runtime/tuple-cache-mgr.cc File be/src/runtime/tuple-cache-mgr.cc: http://gerrit.cloudera.org:8080/#/c/22215/8/be/src/runtime/tuple-cache-mgr.cc@229 PS8, Line 229: FLAGS_tuple_cache_sync_pool_size > Is FLAGS_tuple_cache_sync_pool_size the same as sync_pool_size_? If so, sho Good catch, changed this to sync_pool_size_. http://gerrit.cloudera.org:8080/#/c/22215/8/be/src/runtime/tuple-cache-mgr.cc@441 PS8, Line 441: cache_->Erase(cache_->Key(handle->cache_handle)); > A VLOG_FILE note might be nice here. Done -- To view, visit http://gerrit.cloudera.org:8080/22215 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I646bb56300656d8b8ac613cb8fe2f85180b386d3 Gerrit-Change-Number: 22215 Gerrit-PatchSet: 8 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 21 May 2025 21:24:42 +0000 Gerrit-HasComments: Yes
