Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22872 )
Change subject: IMPALA-12162: Use thread pool to collect checksums ...................................................................... Patch Set 15: (4 comments) http://gerrit.cloudera.org:8080/#/c/22872/15/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java File fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java: http://gerrit.cloudera.org:8080/#/c/22872/15/fe/src/main/java/org/apache/impala/catalog/ParallelFileMetadataLoader.java@131 PS15, Line 131: private static void updatePartBuilders(FileMetadataLoader loader, : List<HdfsPartition.Builder> builders) { nit: A method documentation would be nice to have here. http://gerrit.cloudera.org:8080/#/c/22872/15/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/22872/15/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7876 PS15, Line 7876: String debugAction Should this be "final String"? It passed down to lambda expression below. http://gerrit.cloudera.org:8080/#/c/22872/15/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7883 PS15, Line 7883: Supplier<FileSystem> tableFsSupplier = () -> { : try { : return table.getFileSystem(); : } catch (CatalogException e) { : LOG.warn("Failed to get FileSystem for table {}", table.getFullName(), e); : } : return null; : }; : final FileSystem tableFs = tableFsSupplier.get(); Why this need to use Supplier if only used locally? http://gerrit.cloudera.org:8080/#/c/22872/15/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/22872/15/tests/query_test/test_insert.py@199 PS15, Line 199: # This should take less than 10 seconds to finish. : assert time() - start_time < 10, \ : "Query took too long to finish: {0} seconds".format(time() - start_time) This can be flaky in slow build flavor (ASAN, TSAN, UBSAN). I recommend just remove it, or change to measure metrics instead. -- To view, visit http://gerrit.cloudera.org:8080/22872 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I314621104e4757620c0a90d41dd6875bf8855b51 Gerrit-Change-Number: 22872 Gerrit-PatchSet: 15 Gerrit-Owner: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Sai Hemanth Gantasala <saihema...@cloudera.com> Gerrit-Comment-Date: Thu, 22 May 2025 19:37:35 +0000 Gerrit-HasComments: Yes
